Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(www): upgrade server-list to Lit #1844

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Feb 21, 2024

I struggled getting the server list to show up when running the old macos client, even when running with --buildMode=release. Upgrading this element to Lit resolved it.

@sbruens sbruens requested a review from a team as a code owner February 21, 2024 05:39
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6356371) 32% compared to head (385ae8f) 32%.

Files Patch % Lines
src/www/views/servers_view/server_list/index.ts 38% 11 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1844   +/-   ##
======================================
- Coverage      32%     32%   -1%     
======================================
  Files          45      45           
  Lines        2609    2610    +1     
  Branches      337     337           
======================================
  Hits          859     859           
- Misses       1750    1751    +1     
Flag Coverage Δ
apple 15% <ø> (ø)
maccatalyst 15% <ø> (ø)
macos 15% <ø> (ø)
unittests 32% <38%> (-1%) ⬇️
www 40% <38%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbruens sbruens merged commit 93f2ecd into master Feb 22, 2024
18 of 20 checks passed
@sbruens sbruens deleted the sbruens/server-list-lit branch February 22, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants